Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser log support #81

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Browser log support #81

merged 1 commit into from
Sep 26, 2023

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Sep 26, 2023

This PR brings back support for accessing browser logs in PR logs (I had to adapt the solution to Selenium 4).

Tested in:
https://github.com/ibexa/behat/actions/runs/6311453842/job/17135473909?pr=81

         │  JS Console errors:
        │  	http://web/favicon.ico - Failed to load resource: the server responded with a status of 404 (Not Found)

@mnocon mnocon force-pushed the browser-log-support branch from f12e5b3 to 0cf6700 Compare September 26, 2023 10:54
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon marked this pull request as ready for review September 26, 2023 10:56
@mnocon mnocon merged commit 05448f6 into 4.5 Sep 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants